Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libnetwork package #863

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Dec 16, 2021

Copy the libpod/network packages from podman to here so we can use the
same code in buildah as well.

This is mostly a one to one copy only the import paths have been changed
and some errors were added.

We need the netns package in c/common for the new network code.

Signed-off-by: Paul Holzinger <[email protected]>
Copy the libpod/network packages from podman to here so we can use the
same code in buildah as well.

This is mostly a one to one copy only the import paths have been changed
and some errors were added.

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member Author

Luap99 commented Dec 16, 2021

@mheon @baude PTAL
This is step one to make buildah use netavark.

@flouthoc
Copy link
Collaborator

@Luap99 There are couple of go-critic issues that should be fixed.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
Copy link
Member Author

Luap99 commented Dec 17, 2021

Podman PR containers/podman#12642

@rhatdan
Copy link
Member

rhatdan commented Dec 18, 2021

LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 19, 2021

@containers/podman-maintainers PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It's concerning that the linter didn't bark in Podman CI.

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit 59c0c42 into containers:main Dec 20, 2021
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am late. But LGTM

@Luap99 Luap99 deleted the libnetwork branch December 20, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants