cgroup: retry rmdir up to 5 seconds on EBUSY #858
Merged
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
retry-cgroup-delete
branch
from
8415e3d to
df9a7b3
Compare
on a busy system, the conmon process could take longer to complete or to be reaped by the parent, leaving the cgroup busy. If the rmdir fails with EBUSY, try again up to 5 seconds before reporting an error. Closes: containers/podman#11946 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
retry-cgroup-delete
branch
from
df9a7b3 to
cd108eb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
rhatdan
pushed a commit
to rhatdan/common
that referenced
this pull request
Dec 14, 2021
cgroup: retry rmdir up to 5 seconds on EBUSY Signed-off-by: Daniel J Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on a busy system, the conmon process could take longer to complete or
to be reaped by the parent, leaving the cgroup busy. If the rmdir
fails with EBUSY, try again up to 5 seconds before reporting an
error.
Closes: containers/podman#11946
Signed-off-by: Giuseppe Scrivano [email protected]