Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image and repo defaults for podman machine #852

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

n1hility
Copy link
Member

@n1hility n1hility commented Dec 8, 2021

This PR adds a new platform driven user setting used by the draft PR containers/podman#12503

Additionally it modifies "image" to also have a platform driven default.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/config/config.go Outdated Show resolved Hide resolved
@n1hility
Copy link
Member Author

n1hility commented Dec 8, 2021

You have to documents this in https://github.com/containers/common/blob/main/docs/containers.conf.5.md and add the fields to the default config https://github.com/containers/common/blob/main/pkg/config/containers.conf

Oops sorry I missed that

@n1hility n1hility force-pushed the add-wsl-defaults branch 3 times, most recently from 577bd33 to 1f98c17 Compare December 8, 2021 22:29
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/containers.conf.5.md Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented Dec 9, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n1hility, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 24f3634 into containers:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants