containers.conf: add option to enforce docker.io for compat API #833
Conversation
Add an option to containers.conf as a knob to enforce short-name resolution to Docker Hub in Podman's compatibility REST API. By popular request, turn it on by default. Signed-off-by: Valentin Rothberg <[email protected]>
There was a problem hiding this comment.
Conceptually this is the wrong granularity, because whether unqualified names are short and should trigger search, or shorthands for docker.io, is a property of an individual API client, not of the whole OS.
But, *shrug*, up to Podman to define what its API means now.
|
@rhatdan wanted a knob in containers.conf. While it's a global config, there are a number of otpions that are podman-specific already. I made sure in the description to limit the effect to Podman's compat REST API. |
|
For the record, by “API client” I didn’t mean Podman; I meant things like the Kubelet, /usr/bin/docker (a _specific version of it, actually), and the like — things talking over the AF_UNIX socket. Any one of them can want short names to be interpreted differently (depending specific version that might or might not have a client change necessary to interoperate with projectatomic/docker) — or just as likely, they might be completely unaware of the issue and “just passing user input to a library”. |
|
Thanks for elaborating. Yes, some users would always have to change something/some config. Having this option allows at least to change the behavior. Hard-coding it for the compat API without opting out was something I strongly opposed. |
|
That’s fair. Nowadays, with the single-purpose VM proliferation, a per-system option might be good enough. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add an option to containers.conf as a knob to enforce short-name
resolution to Docker Hub in Podman's compatibility REST API.
By popular request, turn it on by default.
Signed-off-by: Valentin Rothberg [email protected]
@rhatdan @mtrmac PTAL