Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default machine vm size to 100GiB #832

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

vrothberg
Copy link
Member

Context: containers/podman/issues/11712
Signed-off-by: Valentin Rothberg [email protected]

@vrothberg
Copy link
Member Author

@Luap99 @baude @rhatdan PTAL

@Luap99
Copy link
Member

Luap99 commented Nov 18, 2021

To be honest I think the default should be much higher, at least 100 GB. The .qcow2 vm image is only as big as needed and not 100 GB so I think it should be fine to have such a default.

@vrothberg
Copy link
Member Author

That sounds reasonable, @Luap99. Lima is using the very same default: https://github.com/lima-vm/lima/blob/master/pkg/limayaml/default.yaml#L36

@vrothberg vrothberg changed the title increase default machine vm size to 20 increase default machine vm size to 100GiB Nov 19, 2021
@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

@flouthoc
Copy link
Collaborator

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member Author

vrothberg commented Nov 19, 2021

Merge me please

@flouthoc
Copy link
Collaborator

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

@flouthoc: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flouthoc
Copy link
Collaborator

@saschagrunert Could you merge plz.

@rhatdan
Copy link
Member

rhatdan commented Nov 19, 2021

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Nov 19, 2021

@flouthoc I added you as a maintainer.

@openshift-merge-robot openshift-merge-robot merged commit 05fd779 into containers:main Nov 19, 2021
@flouthoc
Copy link
Collaborator

@rhatdan thanks 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants