libimage: speed up image filters #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhatdan PTAL |
This was referenced Oct 19, 2021
With commit 86afb94 the dangling checks have been changed to be compatible with Docker. Since then, the dangling also need to compute children. Speed up the dangling and intermediate checks by computing the layer tree *once* instead of for each filter invocation. **Before:** real 0m10.837s user 0m11.308s sys 0m4.231s **After:** real 0m0.476s user 0m0.478s sys 0m0.151s Context: github.com/containers/podman/issues/11997 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
fix-podman-11997
branch
from
b71d603 to
f745869
Compare
|
It's a little surprising that we call a function that checks a value that's in the caller's scope, but which is never referenced outside of the function, but if the tests pass, the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit 86afb94 the dangling checks have been changed to be
compatible with Docker. Since then, the dangling also need to compute
children.
Speed up the dangling and intermediate checks by computing the layer
tree once instead of for each filter invocation.
Before:
real 0m10.837s
user 0m11.308s
sys 0m4.231s
After:
real 0m0.476s
user 0m0.478s
sys 0m0.151s
Context: github.com/containers/podman/issues/11997
Signed-off-by: Valentin Rothberg [email protected]