Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: load: try docker-archive first #793

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Sep 30, 2021

Make sure to try loading the docker-archive first to account for the
"hybrid tarballs" created by buildkit. docker-archive gets the name
right while oci-archive will not.

Fixes: containers/podman/issues/11619
Signed-off-by: Valentin Rothberg [email protected]

@containers/podman-maintainers PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Make sure to try loading the docker-archive first to account for the
"hybrid tarballs" created by buildkit.  docker-archive gets the name
right while oci-archive will not.

Fixes: github.com/containers/podman/pull/11619
Signed-off-by: Valentin Rothberg <[email protected]>
@baude
Copy link
Member

baude commented Sep 30, 2021

LGTM

@mheon
Copy link
Member

mheon commented Sep 30, 2021

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman load gets wrong image name
4 participants