Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on capatalize logrus messages, remove stutters #787

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Standardize on capatalize logrus messages, remove stutters #787

merged 1 commit into from
Sep 25, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 24, 2021

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwhonce
Copy link
Member

jwhonce commented Sep 24, 2021 •
edited
Loading

/retest

pull timed out

@jwhonce
Copy link
Member

jwhonce commented Sep 24, 2021

LGTM

@jwhonce
Copy link
Member

jwhonce commented Sep 24, 2021

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

@jwhonce: No presubmit jobs available for containers/common@main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 25, 2021

@containers/podman-maintainers PTAL
@vrothberg @TomSweeneyRedHat @mheon PTAL

@flouthoc
Copy link
Collaborator

LGTM

TomSweeneyRedHat
TomSweeneyRedHat reviewed Sep 25, 2021
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit ab0bafe into containers:main Sep 25, 2021
@vrothberg
Copy link
Member

Heads up, this will break Podman's test/system/330-corrupt-images.bats. There's a check for the parent error.

@TomSweeneyRedHat
Copy link
Member

Ping @edsantiago fyi

@edsantiago
Copy link
Member

@TomSweeneyRedHat ack, thanks.This should be an easy fix for whoever does the vendoring.

@vrothberg
Copy link
Member

containers/podman#11737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhatdan @jwhonce @flouthoc @TomSweeneyRedHat @vrothberg @edsantiago @openshift-merge-robot