Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default Rootless Networking to "CNI" for OSX #754

Merged

Conversation

mheon
Copy link
Member

@mheon mheon commented Sep 1, 2021

This should better support rootless CNI usescases.

Fixes containers/podman#11396

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 1, 2021
This should better support rootless CNI usescases.

Fixes containers/podman#11396

Signed-off-by: Matthew Heon <[email protected]>
@mheon mheon force-pushed the rootlessnetworking_cni_osx branch from 9b7e72a to 854253d Compare September 1, 2021 19:57
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member Author

mheon commented Sep 2, 2021

@containers/podman-maintainers PTAL and merge

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[podman machine] Port auto-forwarding does not work in rootless mode and macOS
4 participants