Enable ipv6 for rootless users by default #744
Conversation
|
@AkihiroSuda PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, rugk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks good, but IPv6 is still experimental on slirp4netns, and maybe we should have some consensus on rootless-containers/slirp4netns#259 ( |
|
Also curious, is there any CI that supports IPv6? |
|
@AkihiroSuda Could you look at containers/podman#11062? It looks the ready fd doesn't wait for ipv6 and ipv6 takes a long time before the link gets the addr. (about 2-3 seconds) |
|
How do we get slirp4netns not to be experimental, without any users of it. This being disabled by default is not going to lead many people to use ipv6 in rootless mode, especially when only a couple of people in the world had any idea on how to turn it on. |
Fixes containers/podman#10889 Inspired by @rugk Signed-off-by: Daniel J Walsh <[email protected]>
| @@ -467,7 +467,7 @@ and pods are visible. | |||
|
|
|||
| Path to the slirp4netns binary. | |||
|
|
|||
| **network_cmd_options**=[] | |||
| **network_cmd_options**=["enable_ipv6=true",] | |||
There was a problem hiding this comment.
Can you add the other slirp4netns options to this man page, https://github.com/containers/podman/blob/main/docs/source/markdown/podman-create.1.md#--networkmode---net
|
/lgtm |
Fixes containers/podman#10889
Inspired by @rugk
Signed-off-by: Daniel J Walsh [email protected]