Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPv6 by default for slirp4netns #741

Closed
wants to merge 1 commit into from
Closed

Conversation

rugk
Copy link

@rugk rugk commented Aug 24, 2021

Fixes containers/podman#10889 in case that is the correct thing to change.

Fixes containers/podman#10889 in case that is the correct thing to change.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rugk
To complete the pull request process, please assign mrunalp after the PR has been reviewed.
You can assign the PR to them by writing /assign @mrunalp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Aug 25, 2021

This does not enable it by default, you would need to do this in pkg/config/default.go Man page also should be updated.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we change this default we have to ensure that slirp4netns still works when ipv6 is disabled on the host.

@@ -199,7 +199,7 @@ default_sysctls = [

# Indicates the networking to be used for rootless containers
#
#rootless_networking = "slirp4netns"
#rootless_networking = "slirp4netns:enable_ipv6=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong field. You have to change the network_cmd_options field.

@Luap99
Copy link
Member

Luap99 commented Aug 25, 2021

OK I verified that changing the default is safe on systems with ipv6 disabled. slirp4netns will not fail and ipv6 setup is ignored.

@rugk
Copy link
Author

rugk commented Aug 25, 2021

Uff, well then I'd suggest you'd better change it by yourself. You better know what and where to change it. 🙂

@rugk rugk closed this Aug 25, 2021
@rugk rugk deleted the patch-1 branch August 25, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is IPv6 disabled for rootless/slirp4netns containers?
3 participants