Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space trimming check in sysctl.Validate #736

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Aug 17, 2021

Sync with containers/podman#11224

Signed-off-by: Yan-Ming Li [email protected]

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributing!

pkg/sysctl/sysctl.go Show resolved Hide resolved
pkg/sysctl/sysctl.go Outdated Show resolved Hide resolved
Co-authored-by: Valentin Rothberg <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2021

/approve
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, xatier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xatier
Copy link
Contributor Author

xatier commented Aug 17, 2021

@rhatdan that was quick! 🏎️

pkg/sysctl/sysctl.go Outdated Show resolved Hide resolved
Co-authored-by: Valentin Rothberg <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Aug 20, 2021

/lgtm
Thanks @xatier

@openshift-ci openshift-ci bot added the lgtm label Aug 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8ca8dd9 into containers:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants