Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option for ChownCopiedFiles #677

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

matejvasek
Copy link
Contributor

A new container engine config boolean determining whether files copied into a container should have changed ownership to the primary uid/gid of the container.

@matejvasek
Copy link
Contributor Author

/cc @vrothberg @rhatdan

@openshift-ci openshift-ci bot requested review from rhatdan and vrothberg July 13, 2021 16:22
@rhatdan
Copy link
Member

rhatdan commented Jul 13, 2021

LGTM
Podman currently does this by default?
/approve

@matejvasek
Copy link
Contributor Author

@rhatdan it's little bit more complicated
the podman CLI does chown by default (so it doesn't break existing user code),
however the Docker APIv2 compat endpoints does not do chown (so it doesn't break docker api client expectations)

@matejvasek
Copy link
Contributor Author

@rhatdan I think that the option should only affect the CLI not the compat endpoint

@rhatdan
Copy link
Member

rhatdan commented Jul 13, 2021

SGTM
@containers/podman-maintainers PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, @matejvasek

@vrothberg
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jul 14, 2021
@rhatdan rhatdan merged commit b15e2ff into containers:main Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants