libimage: lookup images by custom platform #622
Conversation
Allow for looking up images via customizable arch, os and variant. This prevents `podman run --arch=xxx` from redundantly pulling down the image if needed. Context: containers/podman/issues/10648 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Before merging, I want to do the plumbing in Podman. |
|
LGTM |
|
/hold cancel |
|
/lgtm |
| options.Architecture = r.systemContext.ArchitectureChoice | ||
| } | ||
| if options.Architecture == "" { | ||
| options.Architecture = runtime.GOARCH |
There was a problem hiding this comment.
This worries me a bit because it loses the distinction between runtime environment and user request: in particular if this gets to c/image (as it seems to via manifestList.LookupInstance, it turns off variant auto-detection and blindly accepts all variants AFAICS.
Allow for looking up images via customizable arch, os and variant.
This prevents
podman run --arch=xxxfrom redundantly pulling down theimage if needed.
Context: containers/podman/issues/10648
Signed-off-by: Valentin Rothberg [email protected]