Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libpod.conf #369

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove libpod.conf #369

merged 1 commit into from
Dec 4, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Dec 4, 2020

We no longer support libpod.conf, remove any code that deals with it.

Signed-off-by: Daniel J Walsh [email protected]

@rhatdan
Remove libpod.conf
c3a85d6 
We no longer support libpod.conf, remove any code that deals with it.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Dec 4, 2020

@containers/podman-maintainers PTAL
@mheon PTAL

vrothberg
vrothberg reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Ciao libpod.conf!

saschagrunert
saschagrunert approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Dec 4, 2020

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 38613c8 into containers:master Dec 4, 2020
@TomSweeneyRedHat
Copy link
Member

I've got to write a "varlink is dead" note, I'll add libpod.conf to that. Is there anything a user who has a highly customized libpod.conf should do to migrate to containers.conf? They can simply rename/move the file to containers.conf if they want to right?

@mheon
Copy link
Member

mheon commented Dec 4, 2020

No - structure is sufficiently different to prevent that - but almost all the settings do have the same names as they did before.

M1cha pushed a commit to M1cha/common that referenced this pull request Dec 20, 2022
@openshift-merge-robot
Merge pull request containers#369 from Luap99/rework-2
b9a0ddb 
firewall types: remove unnecessary clones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@mheon mheon

Labels
3.0 Release approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhatdan @openshift-ci-robot @mheon @TomSweeneyRedHat @saschagrunert @vrothberg @openshift-merge-robot