Add retry helper functions

[QiWang19]

Add retry functions to retry on some commands and can be shared by Skopeo, Podman.

Signed-off-by: Qi Wang [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM
@vrothberg @giuseppe @TomSweeneyRedHat @mheon @mtrmac PTAL

[TomSweeneyRedHat]

LGTM
Would be nice to have tests for these in common, but I'm not coming up with a way quickly...

[vrothberg]

LGTM 👍

[mtrmac]

I’m not sure image is the right name for this subpackage — it might be. But naming the file pull.go just isn’t a good match.

[rhatdan]

@mtrmac What would you prefer, retry.go?

[mtrmac]

c/common/pkg/retry would be my first guess - and retry.go or something like that.

[mheon]

That SGTM. I'm also opposed to the image name (we really have a naming problem already - c/common and c/conmon being a good example - and I'm really not eager to make it worse.

[rhatdan]

The idea was to put Parker short names stuff in the same place, which is why she called it image.
How about we call it common/pkg/pull then we can have retry.go and shortname.go under the common/pkg/pull name?

[mheon]

Sure. pkg/img/pull maybe?

[mtrmac]

We are now discussing this in three different places. Someone please choose one.

[rhatdan]

Let's discuss this in the containers/common PR to rename it.