Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups: improve ENOENT and EBUSY handling #2158

Merged

Conversation

giuseppe
Copy link
Member

writing to cgroup.subtree_control can fail with ENOENT either if the file itself doesn't exist, or a specified controller is not available.

Try to detect the reason and improve the error message.

Adding to help debugging containers/podman#15074

writing to cgroup.subtree_control can fail with ENOENT either if the
file itself doesn't exist, or a specified controller is not available.

Try to detect the reason and improve the error message.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Giuseppe Scrivano <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e2c949d into containers:main Sep 11, 2024
16 checks passed
@giuseppe
Copy link
Member Author

and the vendoring PR for Podman: containers/podman#23926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants