Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor c/storage #2131

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Aug 21, 2024

This PR vendor pre-release version of c/storage:8ec73cadc730 for #2125. It also fixes a linter issue caused by vendoring.

@Honny1 Honny1 marked this pull request as ready for review August 21, 2024 14:11
@rhatdan rhatdan changed the title Vendor c/storage [wip] Vendor c/storage Aug 21, 2024
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The code changes LGTM.

go.mod Outdated Show resolved Hide resolved
@mtrmac
Copy link
Contributor

mtrmac commented Aug 21, 2024

(I suspect that the “Fix SA1019…” and “Vendor containerd/platforms” commits should be squashed because the project wouldn’t build with go.mod and code package references inconsistent.)

Honny1 added 2 commits August 22, 2024 09:51
…orms with github.com/containerd/platforms

Signed-off-by: Jan Rodák <[email protected]>

Vendor containerd/platforms

Signed-off-by: Jan Rodák <[email protected]>
@Honny1 Honny1 requested a review from mtrmac August 22, 2024 08:55
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2024

@Honny1 when you remove [WIP] this should merge.

@Honny1 Honny1 changed the title [wip] Vendor c/storage Vendor c/storage Aug 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 10ced65 into containers:main Aug 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants