Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /usr/libexec to default binary helper dirs #2067

Closed
wants to merge 1 commit into from

Conversation

baude
Copy link
Member

@baude baude commented Jun 27, 2024

The recent addition of virtiofsd to podman now requires podman to resolve the path for the virtiofsd executable. the binary lives in /usr/libexec which is not one of the defaults for Linux. Here I want to add /usr/libexec to the default list.

This fixes containers/podman#23127

The recent addition of virtiofsd to podman now requires podman to
resolve the path for the virtiofsd executable.  the binary lives in
/usr/libexec which is not one of the defaults for Linux.  Here I want to
add /usr/libexec to the default list.

This fixes containers/podman#23127

Signed-off-by: Brent Baude <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member Author

baude commented Jun 27, 2024

@rhatdan @Luap99 should i also change the defaults in pkg/config/containers.conf ? I choose no to because I assume that file needs to be valid on Macs/Windows? If not, happy to add and update the man page too.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the discussions on the machine PR.
containers/podman#22920 (comment)

Add new dirs here is not scalable at all. Other distros do not use this path, etc..
The best way is to add the symlink which is already done in podman-machine.

@Luap99 Luap99 closed this Jun 28, 2024
@baude
Copy link
Member Author

baude commented Jun 28, 2024

I hate this solution. It does nothing for other distributions, developers who use upstream code, etc.

@Luap99
Copy link
Member

Luap99 commented Jun 28, 2024

It does nothing for other distributions

Neither does this PR which is why it is not scalable. We cannot just hard code a bunch of paths here because every distro ships it in a another location.

If you prefer to hard code paths then you can do so on the podman side but again it doesn't scale across distros.

@afbjorklund
Copy link
Contributor

I hate this solution. It does nothing for other distributions, developers who use upstream code, etc.

You also forgot to add /usr/local/libexec to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

virtiofsd not in path breaks podman start
3 participants