Do not validate paths on remote platforms #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baude PTAL |
| func (c *EngineConfig) validatePaths() error { | ||
| // Relative paths can cause nasty bugs, because core paths we use could | ||
| // shift between runs (or even parts of the program - the OCI runtime | ||
| // uses a different working directory than we do, for example. |
There was a problem hiding this comment.
missing an ending paren )
vrothberg
reviewed
May 28, 2020
pkg/config/config_local.go
Outdated
| @@ -0,0 +1,77 @@ | |||
| // +build !remoteclient | |||
There was a problem hiding this comment.
This means Podman has to use this too but libpod is using ABISupport. @baude, cool with that?
There was a problem hiding this comment.
yeah i think it should probably be ABI support ... or be fenced by os !linux
There was a problem hiding this comment.
!linux would be my favourite option.
|
@rhatdan patch works .. please update and lets get merged. |
Modify validate functions to work on a remote clients. Any of the path checks will not work on remote machines or make sense on remote clients. Therefore they should not be checked. Signed-off-by: Daniel J Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify validate functions to work on a remote clients.
Any of the path checks will not work on remote machines or make
sense on remote clients. Therefore they should not be checked.
Signed-off-by: Daniel J Walsh [email protected]