Default to port 22 when dialing

[rhatdan]

[NO NEW TESTS NEEDED]

Fixes: containers/podman#19162

[rhatdan]

@dustymabe PTAL
@giuseppe @vrothberg @Luap99 @containers/podman-maintainers PTAL

[vrothberg]

Code LGTM but I think we need a regression test

[TomSweeneyRedHat]

LGTM
once a test is added

[rhatdan]

Not sure we can get a regression tests without actually connecting to another machine.

[Luap99]

I think you can add a test like:

common/pkg/ssh/ssh_test.go

Line 51 in 6df4458

func TestDial(t *testing.T) {

At least making sure it fails with connection refused and not with the strconv.Atoi error when the port is unset.

[rhatdan]

@Luap99 are you happy with the test?

[Luap99]

I don't see any test here, did you forgot to push?

[rhatdan]

@Luap99 should be there now.

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment