Change secrets Replace to modify the ID

[rhatdan]

We decided that podman secret create --replace should match behaviour of podman container create --replace, so the ID should change.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ashley-cui]

Angry linter but otherwise LGTM

[ashley-cui]

/lgtm
/hold

[vrothberg]

Let's stick to the 2 LGTM rule please. No need to rush things through so close to a release.

[vrothberg]

Test isn't happy yet

--- FAIL: TestAddSecretAndLookupData (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x68 pc=0x5c8263]
goroutine 19 [running]:
testing.tRunner.func1.2({0x5f11c0, 0x7cc170})
/usr/lib/golang/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
/usr/lib/golang/src/testing/testing.go:1529 +0x39f
panic({0x5f11c0, 0x7cc170})
/usr/lib/golang/src/runtime/panic.go:884 +0x213
github.com/containers/common/pkg/secrets.(*SecretsManager).Store(0xc00014c2a0, {0x6278e6, 0x8}, {0xc00012e838, 0x6, 0x6}, {0x6269c5, 0x4}, {0xc00011d740, 0xc00011d7a0, ...})
/var/tmp/go/src/github.com/containers/common/pkg/secrets/secrets.go:209 +0x363
github.com/containers/common/pkg/secrets.TestAddSecretAndLookupData(0xc000103380)
/var/tmp/go/src/github.com/containers/common/pkg/secrets/secrets_test.go:47 +0x24e
testing.tRunner(0xc000103380, 0x6528e8)
/usr/lib/golang/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
/usr/lib/golang/src/testing/testing.go:1629 +0x3ea

[rhatdan]

@vrothberg PTAL

[vrothberg]

Code LGTM

Can we rename Replace to Update?

[ashley-cui]

I think in this case it's replace, where the ID is modified. If the secret ID is not modified, then update is the correct verbiage.

[ashley-cui]

LGTM for replace, we can look at update in a separate patch if needed later on.

/lgtm

[rhatdan]

/hold cancel