pkg/servicereaper: build this for FreeBSD as well as Linux #1531
Conversation
This is needed to support 'podman system service'. Signed-off-by: Doug Rabson <[email protected]>
dfr
force-pushed
the
freebsd-servicereaper
branch
from
3727e65 to
c118afa
Compare
|
So far we only use that for rootlessport/slirp4netns and AFAIK that is not used on freebsd? Maybe it is better to nop the call out in podman on bsd? |
I'll try that - thanks for the extra context |
|
There is a call site in podman/cmd/podman/system/service/service_abi.go which doesn't seem to be related to slirp4netns (unless I'm misunderstanding something). |
|
yeah it calls Start() but that just spawns a goroutine and doesn't do anything useful unless there are other callers the call AddPID() so unless you need a process reaper and plan on using AddPID() there is no reason to call Start(). |
|
Ok, it looks like I don't need this in podman on FreeBSD for now. I'll do some more testing over there and close this PR. |
|
I mean we can merge this here, this package seems to compile fine on freebsd. But it still makes sense to NOP it out for bsd in the podman service as you safe on goroutine (so bit of cpu and memory). |
|
Makes sense - I'll decouple things on the podman side before I make a PR to enable 'podman system service' on FreeBSD |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is needed to support 'podman system service'.