Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add CompressionLevel to containers.conf #1518

Merged
merged 1 commit into from
Jun 21, 2023
Merged

config: add CompressionLevel to containers.conf #1518

merged 1 commit into from
Jun 21, 2023

Conversation

giuseppe
Copy link
Member

No description provided.

@giuseppe giuseppe mentioned this pull request Jun 20, 2023
Merged
@giuseppe giuseppe marked this pull request as draft June 20, 2023 21:34
@rhatdan
Copy link
Member

rhatdan commented Jun 20, 2023

Please update the man page.

@giuseppe giuseppe marked this pull request as ready for review June 20, 2023 21:40
@giuseppe giuseppe force-pushed the config-add-compression-level branch from 500e85b to bab72bb Compare June 20, 2023 21:43
@giuseppe
Copy link
Member Author

Please update the man page.

fixed

@rhatdan
Copy link
Member

rhatdan commented Jun 20, 2023

/approve
LGTM
@vrothberg @Luap99 @mtrmac PTAL

Luap99
Luap99 reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to update docs/containers.conf.5.md as well

@giuseppe giuseppe force-pushed the config-add-compression-level branch from bab72bb to c26fcd2 Compare June 21, 2023 10:06
@giuseppe
Copy link
Member Author

This needs to update docs/containers.conf.5.md as well

fixed now

flouthoc
flouthoc approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flouthoc
flouthoc approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a2cd3ea into containers:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 left review comments

@flouthoc flouthoc flouthoc approved these changes

Assignees

@flouthoc flouthoc

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giuseppe @rhatdan @flouthoc @Luap99 @openshift-merge-robot