refactor(hosts): export hostContainersInternal variable #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
force-pushed
the
export-hostContainersInternal
branch
from
a99c229 to
472f2be
Compare
Because we need to use the value of this variable in podman, exporting this variable means we don't have to hardcode this string in podman. This will make the code easier to maintain. Signed-off-by: Black-Hole1 <[email protected]>
BlackHole1
force-pushed
the
export-hostContainersInternal
branch
from
472f2be to
5041913
Compare
|
@vrothberg Done! 🚀 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlackHole1, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BlackHole1
added a commit
to BlackHole1/podman
that referenced
this pull request
Jun 21, 2023
Use exported variables instead of hard-coded strings. Ref: containers/common#1516 Signed-off-by: Black-Hole1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/containers/podman/pull/18936/files#diff-2c925d6ff6f9b6848d4c49e021e3ca1cc2641d631b871f1a59279a70fc4314deR621