Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override DefaultInitPath for FreeBSD #1496

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Jun 12, 2023

FreeBSD packages typically install files under /usr/local on FreeBSD.

This also 'fixes' pkg/config unit tests on FreeBSD - all except one test already worked and this just skips the capabilities test on FreeBSD. This may not be the right way to skip a test - I'm not at all familiar with the ginkgo test framework.

This just disables the capabilities test - everything else already
passed.

Signed-off-by: Doug Rabson <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nit, LGTM
Thank you!

pkg/config/config_test.go Show resolved Hide resolved
FreeBSD packages typically install files under /usr/local on FreeBSD.

Signed-off-by: Doug Rabson <[email protected]>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Luap99 PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@vrothberg
Copy link
Member

/hold cancel

@Luap99
Copy link
Member

Luap99 commented Jun 12, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3d71cc7 into containers:main Jun 12, 2023
@dfr dfr deleted the freebsd-init branch June 13, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants