-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override DefaultInitPath for FreeBSD #1496
Conversation
This just disables the capabilities test - everything else already passed. Signed-off-by: Doug Rabson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nit, LGTM
Thank you!
FreeBSD packages typically install files under /usr/local on FreeBSD. Signed-off-by: Doug Rabson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Luap99 PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FreeBSD packages typically install files under /usr/local on FreeBSD.
This also 'fixes' pkg/config unit tests on FreeBSD - all except one test already worked and this just skips the capabilities test on FreeBSD. This may not be the right way to skip a test - I'm not at all familiar with the ginkgo test framework.