Use an atomic config write strategy #1397
Conversation
n1hility
force-pushed
the
atomic-write
branch
2 times, most recently
from
87b2cfd
to
451e587
Compare
Yes lets us that please. Also I think it is good to switch the linux version over to the atomic approach as well. If we have a power loss while writing connections it can corrupt the file as well on linux. |
|
@vrothberg @Luap99 just took a look, it needs a behavioral patch for Mac and Windows but happy to switch to it (didn't see this existed , thanks!) The issue is that on both you need syncing to occur after metadata operations (with the exception fo the rename). But it could be a patch to storage to add that. |
|
@n1hility Patching c/storage sounds good, then we just need to make sure that we use this package in the relevant places. |
|
/hold |
n1hility
changed the title
Updates to containers/storage@main (contains a required fswriters PR: containers/storage#1554) [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <[email protected]>
|
/remove-hold PR is now revised as discussed above PTAL @Luap99 @vrothberg @rhatdan |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Part of a set of changes to resolve containers/podman#18011
Uses updated AtomicFileWriter for atomic config file writing on Linux, Mac, and Windows
Updates to containers/storage@main to pull in containers/storage#1554