pkg/report: fix IsJSON() #1226
Merged
pkg/report: fix IsJSON() #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When a user request --format `{{json .}}` they would want the go
template parser to handle it. Currently we overwrite this and assume
that `{{json .}}` equals `json`. This is not correct. When the output is
a range (array), i.e. podman ps, it should return one json object per
line and not a json array which is the case with `json`.
This is required for docker compat.
Fixes containers/podman#16436
Signed-off-by: Paul Holzinger <[email protected]>
|
/hold |
|
containers/podman#16446 for podman tests |
|
/lgtm |
|
wait, the podman PR has red test! This will break vendoring. |
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Nov 8, 2022
The PR containers#1226 was merged to soon, it breaks podman tests and backwards compat. `{{json}}` is not a valid template but it worked before the same as `json` so we should keep that. Fixes up commit 152c840 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Nov 8, 2022
The PR containers#1226 was merged to soon, it breaks podman tests and backwards compat. `{{json}}` and `{{json.}}` are not valid templates but it worked before the same as `json` so we should keep that for compat reasons. Fixes up commit 152c840 Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user request --format
{{json .}}they would want the go template parser to handle it. Currently we overwrite this and assume that{{json .}}equalsjson. This is not correct. When the output is a range (array), i.e. podman ps, it should return one json object per line and not a json array which is the case withjson.This is required for docker compat.
Fixes containers/podman#16436