Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor containers/storage #1195

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 18, 2022

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Oct 18, 2022

@containers/podman-maintainers PTAL

@vrothberg
Copy link
Member

Please update Podman before where c/storage does not pass (see containers/podman#16211).

@vrothberg
Copy link
Member

If we vendor the lower libraries first, we are effectively blocked from vendoring them.

@rhatdan
Copy link
Member Author

rhatdan commented Oct 24, 2022

@containers/podman-maintainers PTAL

@vrothberg
Copy link
Member

Is this stuff already vendored in Podman?

@vrothberg
Copy link
Member

There's a merge conflict.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Oct 24, 2022

@Luap99
Copy link
Member

Luap99 commented Oct 25, 2022

/lgtm

@vrothberg
Copy link
Member

Please don't ignore my above comments

Is this stuff already vendored in Podman?

Podman is still not using recent c/storage (see https://github.com/containers/podman/blob/main/go.mod#L151). We are still running blind w.r.t. Podman CI passing on c/storage@main.

@openshift-merge-robot openshift-merge-robot merged commit 3a4361d into containers:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants