libimage: add LayersDiskUsage #1191
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add an API to query the sum of the layer sizes. This data is needed to fix containers/podman/issues/16135. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
fix-podman-16135
branch
from
cbe8b45 to
46db018
Compare
|
A little bit of concern about this with AdditionalStores, but this is better then what we have now. /lgtm |
|
Can you elaborate on your concerns, @rhatdan? |
|
Do users expect to get all of the usage back if they remove all layers, since the removal will not remove AdditionalStore layers. |
I would be surprised if users would expect read-only images to be cleaned up. |
|
I agree, I just see them being confused. If I list out how much space layers are taking, then they might expect that resetting will free up X storage, but when they clean, they will end up only removing X-y storage, where y is in additional images. |
|
Most people don't use additional stores, so it should not be a problem, but Edge seems to be adopting AdditionalStores as core principal, for OS Image based containers. |
|
/hold cancel |
Add an API to query the sum of the layer sizes. This data is needed to fix containers/podman/issues/16135.
Signed-off-by: Valentin Rothberg [email protected]