Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for returning image path with ARCH and OS Substitutions #1119

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Aug 15, 2022

Allow distributions to specify the location of the podman image VM
images in the form of URIs with $ARCH and $OS specified. This would
allow a distribution to pull the image based on the current OS and Arch.

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Aug 15, 2022

@baude PTAL

@rhatdan rhatdan force-pushed the path branch 4 times, most recently from cc97c8e to 1efd98b Compare August 22, 2022 10:24
Allow distributions to specify the location of the podman image VM
images in the form of URIs with $ARCH and $OS specified.  This would
allow a distribution to pull the image based on the current OS and Arch.

Signed-off-by: Daniel J Walsh <[email protected]>
@ashley-cui
Copy link
Member

LGTM

@baude
Copy link
Member

baude commented Aug 23, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 72a7da3 into containers:main Aug 23, 2022
cdoern pushed a commit to cdoern/common that referenced this pull request Aug 26, 2022
Add support for returning image path with ARCH and OS Substitutions

Signed-off-by: Charlie Doern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants