libimage, ManifestList: fslock and reload to provide race-free Add API
#1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`podman manifest add` uses `ManifestList.Add(` but of now `Add(` does not locks while adding instances to the list thus causing race scenarios where storage is not reloaded and overrided by another invocation of the command. Following problem is solved in two steps * Add -> LockByInstance: Acquire a fs lock by instance ID so other invocation waits until this invocation completes its write. * Add -> LockByInstance -> reload: Reload instance digests from storage just after acquiring lock to make sure we are not overriding any just written instance. Reproducer: containers/podman#14667 (comment) Closes: containers/podman#14667 [NO NEW TESTS NEEDED] [NO TESTS NEEDED] This needes integration tests so its hard to verify race in CI. Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
race-free-manifest-add
branch
from
b7ed55c to
8a786cc
Compare
|
/approved |
|
LGTM, but I'd like an ack from @vrothberg before we merge |
vrothberg
approved these changes
Jul 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Thanks, Syncing this to buildah and podman so i can update the BZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman manifest addusesManifestList.Add(but as of nowAdd(doesnot locks while adding instances to the list thus causing race scenarios
where storage is not reloaded and overridden by another invocation of the
command.
Following problem is solved in two steps
invocation waits until this invocation completes its write.
just after acquiring lock to make sure we are not overriding any just
written instance.
Reproducer: containers/podman#14667 (comment)
Closes: BZ#2105173
Closes: containers/podman#14667
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]
This needs integration tests so its hard to verify race in c/common CI