move code from Podman so it can be shared with conmon-rs #1083
Conversation
conmon-rs currently depends on podmans pkg/kubeutils. Since podman wants to import conmon-rs go code this can cause many problems. To fix this we move the shared code to c/common so both projects can use it without trouble. Also rename the package to pkg/resize from kubeutils since this contains really only one function and the name is much more clear. see containers/conmon-rs#504 Signed-off-by: Paul Holzinger <[email protected]>
conmon-rs currently depends on podmans utils.CopyDetachable(). Since podman wants to import conmon-rs go code this can cause many problems. To fix this we move the shared code to c/common so both projects can use it without trouble. see containers/conmon-rs#504 Signed-off-by: Paul Holzinger <[email protected]>
|
LGTM, though, can you think of any reason not just to have them in conmonrs? |
|
they could still be imported by podman (once conmon-rs is being vendored), and ideally all of these would be used strictly by the conmon-rs client in the future |
That would also work but I personally prefer to have shared code in c/common. |
CopyDetachable is also used on the podman-remote side (pkg/bindings) |
|
LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
see the commit descriptions and containers/conmon-rs#504