libimage: pull: warn if platforms do not match #1052
Merged
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
May 30, 2022
flouthoc
reviewed
May 30, 2022
| if writer == nil { | ||
| logrus.Debugf("WARNING: %s", msg) | ||
| } else { | ||
| fmt.Fprintf(writer, "WARNING: %s\n", msg) |
There was a problem hiding this comment.
Should this be also logrus.Warnf
There was a problem hiding this comment.
No, I want this on the writer. This way, it'll be displayed on the remote clients as well.
Warn when the platform of a pulled image does not match the user-specified platform. The checks are only performed if the user requested a custom platform. Do not error out and warn only since there are many images in the wild that claim to be of another architecture. An error would break existing workloads; we did that once and had to revert immediately. Fixes: containers/podman/issues/14293 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
platform-check-warning
branch
from
1a9e70b to
8cc89fa
Compare
|
@flouthoc good to merge? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn when the platform of a pulled image does not match the
user-specified platform. The checks are only performed if the user
requested a custom platform.
Do not error out and warn only since there are many images in the wild
that claim to be of another architecture. An error would break existing
workloads; we did that once and had to revert immediately.
Fixes: containers/podman/issues/14293
Signed-off-by: Valentin Rothberg [email protected]