Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config changes and pkg/parse fixes for FreeBSD #1026

Merged
merged 4 commits into from
May 10, 2022
Merged

Config changes and pkg/parse fixes for FreeBSD #1026

merged 4 commits into from
May 10, 2022

Conversation

dfr
Copy link
Contributor

@dfr dfr commented May 8, 2022

No description provided.

@rhatdan
Copy link
Member

rhatdan commented May 8, 2022

LGTM
/approve
@containers/podman-maintainers PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 8, 2022
@rhatdan
Copy link
Member

rhatdan commented May 8, 2022

Builds are failing.

@dfr
Copy link
Contributor Author

dfr commented May 8, 2022

Looks like I broke the cross build (again). I'll fix it tomorrow morning.

@dfr dfr force-pushed the freebsd branch 2 times, most recently from 3911d10 to deed09d Compare May 9, 2022 12:08
@jwhonce
Copy link
Member

jwhonce commented May 10, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

@jwhonce: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented May 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit eb7cd4c into containers:main May 10, 2022
@dfr dfr deleted the freebsd branch June 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfr @rhatdan @jwhonce @openshift-merge-robot