Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update containers/storage #846

Closed
wants to merge 1 commit into from

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Jul 4, 2018

Update to version 58f557cf12df3e11437485f329c15b5c20bebb90

Signed-off-by: Giuseppe Scrivano [email protected]

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, just wondering if we should hold until containers/image#472 merges.

@giuseppe
Copy link
Member Author

giuseppe commented Jul 4, 2018

@TomSweeneyRedHat this changes only containers/storage not containers/image. I am wondering more about: containers/storage#137 that I'd like to include as well in our tools 😄

@TomSweeneyRedHat
Copy link
Member

DOH! You're right, I must be having too much July 4th fun. A straight LGTM then.

@rhatdan
Copy link
Member

rhatdan commented Jul 5, 2018

@giuseppe I merged the OSTree support, so update to pull that in.

@giuseppe giuseppe force-pushed the vndr-storage branch 3 times, most recently from a217b50 to 179782c Compare July 5, 2018 13:49
Update to version 9cbb6cb3fc2044eae8b8fd8d8da081fe812858c4

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe
Copy link
Member Author

giuseppe commented Jul 5, 2018

@rhatdan done ⬆️

@rhatdan
Copy link
Member

rhatdan commented Jul 5, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 7c701e5 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 7c701e5 with merge 733cd20...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: rhatdan
Pushing 733cd20 to master...

@rhatdan
Copy link
Member

rhatdan commented Jul 6, 2018

@giuseppe Could you write up a couple of blogs on why these versions of container/storage are important and useful.

@giuseppe
Copy link
Member Author

giuseppe commented Jul 6, 2018

yes, I'll do that. In the last days I've done a lot of improvements in https://github.com/giuseppe/containerfs and solved all the design issues I didn't like. I think it is in a good shape for a tech preview.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants