-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add quotes to names #5765
Conversation
In podman we also run the bud tests, there I noticed a issue with the podman skip logic as it was unable to fine the build-add-https-retry-ca test name as it always expects quotes[1] In general names should be human readable so add quotes and use spaces over a dash as word separator. [1] containers/podman#24135 Signed-off-by: Paul Holzinger <[email protected]>
@edsantiago PTAL |
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
LGTM. Thank you! |
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b93b1df
into
containers:main
In podman we also run the bud tests, there I noticed a issue with the podman skip logic as it was unable to fine the build-add-https-retry-ca test name as it always expects quotes[1]
In general names should be human readable so add quotes and use spaces over a dash as word separator.
[1] containers/podman#24135
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?