Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using ubi8 #4397

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Stop using ubi8 #4397

merged 1 commit into from
Nov 3, 2022

Conversation

edsantiago
Copy link
Member

First: because we have a bunch of tests that rely on the image
manifest list, and ubi8 is not under our control: we've already
seen where ubi8 gets changed without our knowledge, requiring
almost a week of scrambling to get things fixed again.

Second, the registry it lives on is unreliable.

Signed-off-by: Ed Santiago [email protected]

None

@@ -3,5 +3,5 @@ FROM docker.io/library/alpine
COPY Dockerfile.no-run /root/
# A different base image that is known to be a manifest list, supporting a
# different but partially-overlapping set of platforms.
FROM registry.access.redhat.com/ubi8-micro
FROM quay.io/libpod/testimage:20221018
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME FIXME FIXME FIXME!!!

I can't use $SAFEIMAGE here. No matter where I put ARG SAFEIMAGE (line 1 at top, or line 5 just above the FROM), buildah barfs with:

Error: resolving image name "$SAFEIMAGE": cannot parse input: "$SAFEIMAGE": invalid reference format

But it works perfectly fine in the other test. Help please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: the culprit is --all-platforms. It looks like --all-platforms cannot be combined with --build-args. Sounds like a bug to me, should I file an issue? Or is this a yeah-deal-with-it thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flouthoc PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

First: because we have a bunch of tests that rely on the image
manifest list, and ubi8 is not under our control: we've already
seen where ubi8 gets changed without our knowledge, requiring
almost a week of scrambling to get things fixed again.

Second, the registry it lives on is unreliable.

Signed-off-by: Ed Santiago <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Nov 3, 2022

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants