Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.20] do not set the inheritable capabilities #4260

Conversation

nalind
Copy link
Member

@nalind nalind commented Sep 19, 2022

The kernel never sets the inheritable capabilities for a process, they are only set by userspace. Emulate the same behavior.

Closes: CVE-2022-27651

Cherry-picked from GHSA-c3g4-w6cv-6v7h.

@rhatdan
Copy link
Member

rhatdan commented Sep 19, 2022

LGTM

giuseppe and others added 2 commits September 19, 2022 11:37
The kernel never sets the inheritable capabilities for a process, they
are only set by userspace.  Emulate the same behavior.

Closes: CVE-2022-27651

Signed-off-by: Giuseppe Scrivano <[email protected]>
Check that the inheritable capabilities are set to 0, even when we
explicitly try to add capabilities.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@nalind nalind force-pushed the inheritable-capabilities-1.20 branch from f25152f to 77fdaa4 Compare September 19, 2022 15:37
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6796205 into containers:release-1.20 Sep 19, 2022
@nalind nalind deleted the inheritable-capabilities-1.20 branch September 19, 2022 17:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants