copier: add NoOverwriteNonDirDir option
#4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
commented
Jun 7, 2022
vrothberg
force-pushed
the
nondirdir
branch
2 times, most recently
from
e22e0e6 to
7192a9d
Compare
nalind
approved these changes
Jun 7, 2022
Similar to the `NoOverwriteDirNonDir` one, add an option that disables non-directories from being overwritten by directories. Required-for: containers/podman/issues/14420 Signed-off-by: Valentin Rothberg <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
CI queue seems slow today. |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
NoOverwriteDirNonDirone, add an option that disablesnon-directories from being overwritten by directories.
Required-for: containers/podman/issues/14420
Signed-off-by: Valentin Rothberg [email protected]
What type of PR is this?
What this PR does / why we need it:
Add a new option to copier.Put to throw an error if a non-dir is overwritten with a dir. Needed for Docker-compat in
podman cp.How to verify it
go test -v ./copier.Does this PR introduce a user-facing change?
@nalind PTAL