Cirrus: Update CI VMs to F36 #3931
Conversation
| // strings.Title is deprecated since go 1.18 | ||
| // However for our use case it is still fine. The recommended replacement | ||
| // is adding about 400kb binary size so lets keep using this for now. | ||
| //nolint:staticcheck |
There was a problem hiding this comment.
Should we add a TODO or similar tag so we can more easily find this?
There was a problem hiding this comment.
Hrmmm, I dunno. I literally copy-pasted @Luap99 fix from podman. Paul?
There was a problem hiding this comment.
I don't think it is a problem. Since it is in the stdlib it will stay there until golang decides to actively break code.
There was a problem hiding this comment.
better question why do we have this package? I thought we have this in c/common.
cc @jwhonce
|
Tests aren't hip |
Port of fix from podman-land: containers/podman@62f4ae9 Thanks to [email protected] for figuring this out. [NO NEW TESTS NEEDED] Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind other
What this PR does / why we need it:
Bump Fedora VM to version 36 and prior-Fedora to 35
How to verify it
All CI will pass
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Ref: containers/automation_images#115
Does this PR introduce a user-facing change?
None
[NO NEW TESTS NEEDED]