-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build, commit: allow removing default identity labels using --identity-labels=false
#3829
build, commit: allow removing default identity labels using --identity-labels=false
#3829
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bfec769
to
518cf30
Compare
Could you change the option to --identify-labels with a default value of true. Then user could type --identify-labels=false. Shorter to type. |
@rhatdan Would using default |
In the remote protocol, it should be an optional bool and only set when the user sets it. Otherwise it defaults to true. |
518cf30
to
cc70bd3
Compare
cc70bd3
to
0aefb71
Compare
--remove-identity-labels
--identity-labels=false
0aefb71
to
eb3bbf6
Compare
Allow end users to remove default identity labels if they want to. Since there are instances where images can be reproduced across version hence users must have option to suppress default labels. Closes: containers#3826 Signed-off-by: Aditya R <[email protected]>
eb3bbf6
to
e81dd79
Compare
LGTM |
@nalind @TomSweeneyRedHat PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Allow end users to remove default identity labels if they want to.
Since there are instances where images can be reproduced across version
hence users must have option to suppress default labels.
Closes: #3826