Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, commit: allow removing default identity labels using --identity-labels=false #3829

Merged

Conversation

flouthoc
Copy link
Collaborator

Allow end users to remove default identity labels if they want to.
Since there are instances where images can be reproduced across version
hence users must have option to suppress default labels.

Closes: #3826

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flouthoc flouthoc force-pushed the remove-identity-label branch from bfec769 to 518cf30 Compare March 21, 2022 09:41
@flouthoc flouthoc requested review from nalind and rhatdan March 21, 2022 10:49
@rhatdan
Copy link
Member

rhatdan commented Mar 21, 2022

Could you change the option to --identify-labels with a default value of true.

Then user could type --identify-labels=false. Shorter to type.
Or perhaps --idlabels=false.

@flouthoc
Copy link
Collaborator Author

@rhatdan Would using default true cause problem for cases where podman remote / API or other tools which directly call buildah and initialize option in structs, we will have to instrument all such occurrences of code to set default true however as of now they will just not set the field and it will remain false.

@rhatdan
Copy link
Member

rhatdan commented Mar 22, 2022

In the remote protocol, it should be an optional bool and only set when the user sets it. Otherwise it defaults to true.

@flouthoc flouthoc force-pushed the remove-identity-label branch from 518cf30 to cc70bd3 Compare March 28, 2022 07:23
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@flouthoc flouthoc force-pushed the remove-identity-label branch from cc70bd3 to 0aefb71 Compare March 28, 2022 07:25
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@flouthoc
Copy link
Collaborator Author

@nalind @rhatdan PTAL

@flouthoc flouthoc changed the title build, commit: allow removing default identity labels using --remove-identity-labels build, commit: allow removing default identity labels using --identity-labels=false Mar 28, 2022
pkg/cli/common.go Outdated Show resolved Hide resolved
@flouthoc flouthoc force-pushed the remove-identity-label branch from 0aefb71 to eb3bbf6 Compare March 29, 2022 04:21
@flouthoc
Copy link
Collaborator Author

@rhatdan @TomSweeneyRedHat @nalind PTAL

Allow end users to remove default identity labels if they want to.
Since there are instances where images can be reproduced across version
hence users must have option to suppress default labels.

Closes: containers#3826

Signed-off-by: Aditya R <[email protected]>
@flouthoc flouthoc force-pushed the remove-identity-label branch from eb3bbf6 to e81dd79 Compare April 4, 2022 05:37
@rhatdan
Copy link
Member

rhatdan commented Apr 4, 2022

LGTM

@flouthoc
Copy link
Collaborator Author

flouthoc commented Apr 6, 2022

@nalind @TomSweeneyRedHat PTAL

@rhatdan
Copy link
Member

rhatdan commented Apr 6, 2022

@giuseppe @vrothberg @saschagrunert PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: option to suppress io.buildah.version labels
6 participants