Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tests: fix accidental vandalism of source dir #3761

Merged

Conversation

edsantiago
Copy link
Member

The unfortunate TESTDIR (singular) vs TESTSDIR (plural) naming
scheme bit us again, in a new containers_conf test. End result
was that the test could only be run once, and would fail on
subsequent tries. Fix, and fix broken indentation too.

Signed-off-by: Ed Santiago [email protected]

The unfortunate TESTDIR (singular) vs TESTSDIR (plural) naming
scheme bit us again, in a new containers_conf test. End result
was that the test could only be run once, and would fail on
subsequent tries. Fix, and fix broken indentation too.

Signed-off-by: Ed Santiago <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Feb 1, 2022

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2f6e10b into containers:main Feb 1, 2022
@edsantiago edsantiago deleted the dont_vandalize_testdir branch February 1, 2022 18:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants