caps: fix buildah run --cap-add=all

[r10r]

Fixes #3755

[r10r]

/assign @TomSweeneyRedHat

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: r10r
To complete the pull request process, please ask for approval from tomsweeneyredhat after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

Please add a test or add [NO NEW TESTS ADDED]

LGTM

[rhatdan]

Could you check in Podman if we have the same problem.

[r10r]

I'll take a look at the tests and podman.
Btw. can I update the --cap-add documentation as well and mention the all value or should it not be promoted and stay a hidden feature ?

[rhatdan]

Yes update the documentation to add "add" value.

[TomSweeneyRedHat]

LGTM once docs and tests are added. TYVM @r10r !

[rhatdan]

@r10r I took this over and added the no new test flag, so we can get it into a release.

[r10r]

@rhatdan Nice. Are tests required anyway ? I can then create a separate pull request.
I'm just about to look at the test suite because I'll create another pull request in a minute for which tests seem to be mandatory;)

[r10r]

@rhatdan Do you take care of updating the documentation and looking at podman as well ?

[rhatdan]

No if you want to open a separate PR for those it would be great. I am just trying to get the release out.