bud.bats: use a local git daemon for the git protocol test #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/failing-test
When testing that we can handle contexts that are described using the git:// protocol, launch a local git-daemon with a minimal repository to point the binary at instead of github, which doesn't do that any more. Signed-off-by: Nalin Dahyabhai <[email protected]>
flouthoc
approved these changes
Jan 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tests are passing because we now skip a test when we can't launch |
|
/lgtm |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jan 11, 2022
Emergency workaround for github's deprecation of git:// https://github.blog/2021-09-01-improving-git-protocol-security-github/ Two buildah tests rely on 'git://' URLs. These now fail. They have been fixed in the buildah repo[1] but it will take time to vendor that in. ITM, we need to get CI passing. Skip those two failing tests. [1] containers/buildah#3701 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jan 12, 2022
[backport of containers#12818] Emergency workaround for github's deprecation of git:// https://github.blog/2021-09-01-improving-git-protocol-security-github/ Two buildah tests rely on 'git://' URLs. These now fail. They have been fixed in the buildah repo[1] but it will take time to vendor that in. ITM, we need to get CI passing. Skip those two failing tests. [1] containers/buildah#3701 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jan 12, 2022
[backport of containers#12818] Emergency workaround for github's deprecation of git:// https://github.blog/2021-09-01-improving-git-protocol-security-github/ Two buildah tests rely on 'git://' URLs. These now fail. They have been fixed in the buildah repo[1] but it will take time to vendor that in. ITM, we need to get CI passing. Skip those two failing tests. [1] containers/buildah#3701 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Jan 12, 2022
[backport of containers#12818] Emergency workaround for github's deprecation of git:// https://github.blog/2021-09-01-improving-git-protocol-security-github/ Two buildah tests rely on 'git://' URLs. These now fail. They have been fixed in the buildah repo[1] but it will take time to vendor that in. ITM, we need to get CI passing. Skip those two failing tests. [1] containers/buildah#3701 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added a commit
to edsantiago/buildah
that referenced
this pull request
Jan 13, 2022
...by bumping up the CI VM ID to ones that include the git-daemon (Fedora) or git-daemon-run (Ubuntu) packages. Reason: containers#3701 rewrote some tests to work around github closing 'git://' protocol access... but those new tests were simply being skipped. Reference: containers/podman#12851 Signed-off-by: Ed Santiago <[email protected]>
edsantiago
added a commit
to edsantiago/buildah
that referenced
this pull request
Apr 4, 2022
One is a certificate error:
$ buildah push --tls-verify=true alpine localhost:5000/my-alpine
Get "https://localhost:5000/v2/": x509: certificate relies on legacy Common Name field, use SANs instead
This was addressed in containers#3014, but back then it failed with "use
SANs or set a magic DEBUG envariable"; that envariable no longer
works.
The other two errors are due to github no longer supporting git:// URLs.
This was addressed in containers#3701, but that's too hard to backport, so let's
just skip the failing tests.
Signed-off-by: Ed Santiago <[email protected]>
|
/cherrypick release-1.21 |
|
@lsm5: #3701 failed to apply on top of branch "release-1.21": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
When testing that we can handle contexts that are described using the git:// protocol, launch a local git-daemon with a minimal repository to point the binary at instead of github, which doesn't do that any more.
How to verify it
The test should pass now.
Which issue(s) this PR fixes:
Special notes for your reviewer:
We do need git-daemon in the test environment.
Does this PR introduce a user-facing change?