Allow callers to replace the ContainerPrefix

[rhatdan]

This idea of this PR is to allow Podman to add a Podman
prefix to containers. This would allow it to keep track
of containers created by Podman and make it easier to remove
them when it wants to remove all.

Signed-off-by: Daniel J Walsh [email protected]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[vrothberg]

s/Prefix/Suffix/ in the commit message.

[vrothberg]

CI is barking due to missing tests. Would it make sense to expose this as a (hidden) flag in buildah build to make sure we catch regressions early?

[flouthoc]

Could you also add related issue to this PR. I am unable to check why do we need prefix in container names.
Since user could only remove podman containers.

[flouthoc]

Could you also add related issue to this PR. I am unable to check why do we need prefix in container names.
Since user could only remove podman containers.

Nevermind I think I got the issue containers/podman#12353 (comment) . PR has intention to make podman smart about the build container it generates via buildah so leaked containers could be cleaned up.

[rhatdan]

@flouthoc correct, if we suffix the containers with _internal_podman, then we know we can blow them away on a rm -f --all.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ashley-cui]

LGTM