Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LocalIP public function so Podman can use it #3645

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 22, 2021

[NO NEW TESTS NEEDED]

Needed for containers/podman#12375

Signed-off-by: Daniel J Walsh [email protected]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Nov 22, 2021

@mheon @Luap99 PTAL

@mheon
Copy link
Member

mheon commented Nov 22, 2021

Maybe go a step further and throw this into c/common?

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Nov 22, 2021

I was thinking of that, but right now containers/common does not have a util pkg. It does have a pkg/defaultnet, which does not seem appropriate. Theoretically we could change it to pkg/net, and then move a bunch of these over.
Anyways the container_internal_linux.go is currently using buildah/util, so it made sense to put the code here.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan changed the title Make getLocalIP public function so Podman can use it Make LocalIP public function so Podman can use it Nov 22, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7ea8142 into containers:main Nov 23, 2021
@flouthoc
Copy link
Collaborator

LGTM, for the record.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants