-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: support the variant field #3615
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ef5a382
to
ba8c51e
Compare
LGTM |
Could you add a test for buildah config --variant ... |
ba8c51e
to
dc78c67
Compare
Added. |
dc78c67
to
d718b51
Compare
Add the variant field, along with methods for setting and querying it, and expose them in the `buildah config` and `buildah inspect` commands. When setting an initial architecture for a container based on an image which doesn't contain an architecture, or from "scratch", normalize the architecture name we've been given, and set both it and the variant field at the same time. Provide normalized architecture+variant values in `buildah info`. Signed-off-by: Nalin Dahyabhai <[email protected]>
d718b51
to
9f9f32c
Compare
I don't see --variant added? buildah from scratch |
The "config" test in config.bats does that for both OCI and Docker formats, so I added it there as another option/result combination that it checks. |
OK. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add the
variant
field, along with methods for setting and querying it, and expose them in thebuildah config
andbuildah inspect
commands.When setting an initial architecture for a container based on an image which doesn't contain an architecture, or from "scratch", normalize the architecture name we've been given, and set both it and the variant field at the same time.
Provide normalized architecture+variant values in
buildah info
.How to verify it
New integration test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?