-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install new manpages to correct sections #3489
Conversation
Signed-off-by: Reinhard Tartler <[email protected]>
currently found as distro patch at https://salsa.debian.org/go-team/packages/golang-github-containers-buildah/-/blob/debian/sid/debian/patches/build-source-manpages.patch Without this patch, the package build breaks because dh_installmanpages fails to identify the directory where to install the manpage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @siretart!
LGTM
@ashley-cui @TomSweeneyRedHat @nalind PTAL
LGTM. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks!
I think re-base is needed. @siretart Could you please rebase |
ah it needs an approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, siretart The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Reinhard Tartler [email protected]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?