Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install new manpages to correct sections #3489

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

siretart
Copy link
Contributor

Signed-off-by: Reinhard Tartler [email protected]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@siretart
Copy link
Contributor Author

currently found as distro patch at https://salsa.debian.org/go-team/packages/golang-github-containers-buildah/-/blob/debian/sid/debian/patches/build-source-manpages.patch

Without this patch, the package build breaks because dh_installmanpages fails to identify the directory where to install the manpage.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nalind
Copy link
Member

nalind commented Aug 30, 2021

LGTM. Thanks!

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks!

@flouthoc
Copy link
Collaborator

I think re-base is needed. @siretart Could you please rebase

@ashley-cui
Copy link
Member

ashley-cui commented Aug 30, 2021

ah it needs an approve
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, siretart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4d22922 into containers:main Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants