tag: Support tagging manifest list instead of resolving to images #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
force-pushed
the
support-tagging-manifest-list
branch
2 times, most recently
from
d936163 to
11e2bdc
Compare
|
/hold till containers/common#747 is merged and synced |
flouthoc
force-pushed
the
support-tagging-manifest-list
branch
from
11e2bdc to
af60968
Compare
|
was the file |
|
@giuseppe yes my bad i do that all the time, removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrothberg @giuseppe We have a dependency on containers/common#747 |
vrothberg
reviewed
Aug 27, 2021
|
/hold |
|
Changes LGTM, but smoke test is smoking! |
flouthoc
force-pushed
the
support-tagging-manifest-list
branch
5 times, most recently
from
cd59399 to
c9b6e27
Compare
|
@vrothberg PTAL |
vrothberg
reviewed
Aug 30, 2021
flouthoc
force-pushed
the
support-tagging-manifest-list
branch
from
c9b6e27 to
049a931
Compare
|
@vrothberg @giuseppe Vendor-ed the latest c/common@main. PTAL |
vrothberg
reviewed
Aug 30, 2021
Following commit makes sure when `buildah tag` is invoked on a manifest list, it tags the same manifest list instead of resolving image and tagiing it. Signed-off-by: Aditya Rajan <[email protected]>
flouthoc
force-pushed
the
support-tagging-manifest-list
branch
from
049a931 to
82eedac
Compare
|
/hold cancel |
|
my bad waiting for tests |
|
/hold |
|
/hold cancel |
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Oct 21, 2021
Following commit makes sure when buildah tag is invoked on a manifest list, it tags the same manifest list instead of resolving to an image and tagging it. Port of: containers/buildah#3483 Signed-off-by: Aditya Rajan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following commit makes sure when
buildah tagis invoked on a manifestlist, it tags the same manifest list instead of resolving to an image and
tagging it.
Depends-on: containers/common#747